feat: support generics in rxui.ViewModel#293
Merged
CrystalWindSnake merged 5 commits intoCrystalWindSnake:mainfrom May 18, 2025
Merged
feat: support generics in rxui.ViewModel#293CrystalWindSnake merged 5 commits intoCrystalWindSnake:mainfrom
CrystalWindSnake merged 5 commits intoCrystalWindSnake:mainfrom
Conversation
Contributor
Author
|
如果你用的是低版本的python的话，我把test里面的generics改改 |
Owner
|
@changhe3 谢谢你的 PR 🙂 。测试没有通过，测试是基于 python 3.8 的，请修改一下测试中的泛型写法。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently any subclasses of rxui.ViewModel cannot use generic parameters. Add
super().__init_subclass__(**kwargs)to support generics.