Skip to content

feat(p2p-06): add p2p service lifecycle shell (#671)#757

Open
jlon wants to merge 12 commits intoCurvineIO:mainfrom
jlon:p2p-06-service-lifecycle-shell
Open

feat(p2p-06): add p2p service lifecycle shell (#671)#757
jlon wants to merge 12 commits intoCurvineIO:mainfrom
jlon:p2p-06-service-lifecycle-shell

Conversation

@jlon
Copy link
Copy Markdown
Contributor

@jlon jlon commented Mar 26, 2026

Summary

  • Introduce P2pService lifecycle ownership in the client filesystem stack.
  • Keep reads unchanged; this PR only establishes start/stop and stats shell behavior.

Design

  • Model service state explicitly as Disabled, Stopped, and Running.
  • Keep ownership in FsContext and bind startup/shutdown to filesystem lifecycle boundaries.

Implementation

  • Add P2pService, P2pState, and stats snapshot exports.
  • Construct the service from config and hook filesystem start/stop plus basic lifecycle tests.

Verification

  • cargo test -p curvine-client disabled_service_does_not_start
  • cargo test -p curvine-client enabled_service_transitions_between_stopped_and_running
  • cargo test -p curvine-client fs_context_creates_p2p_service_when_enabled

@jlon
Copy link
Copy Markdown
Contributor Author

jlon commented Mar 26, 2026

Part 6/17 of the split P2P series that supersedes #671.

This PR targets , so the visible diff is cumulative. Review the slice described in this PR body instead of treating the whole diff as new.

Intended review delta is p2p-06 on top of #758.

@jlon
Copy link
Copy Markdown
Contributor Author

jlon commented Mar 26, 2026

Review note: this is part 6/17 of the split P2P series that supersedes #671.

This PR targets main, so the visible diff is cumulative. Please review the slice described in this PR body.

Review after #758.

@jlon jlon force-pushed the p2p-06-service-lifecycle-shell branch from 2d9bc06 to 564aa24 Compare March 26, 2026 10:26
@jlon jlon force-pushed the p2p-06-service-lifecycle-shell branch from 564aa24 to dab5fb3 Compare March 27, 2026 09:32
@jlon jlon force-pushed the p2p-06-service-lifecycle-shell branch from dab5fb3 to 311b4d6 Compare March 30, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant