Skip to content

Magento 2.4.6 support#5

Merged
samipel merged 12 commits intoCustobar:masterfrom
vaimo:feature/CUSTO-40-support-246
Jul 14, 2023
Merged

Magento 2.4.6 support#5
samipel merged 12 commits intoCustobar:masterfrom
vaimo:feature/CUSTO-40-support-246

Conversation

@jooname
Copy link
Copy Markdown
Contributor

@jooname jooname commented Jul 7, 2023

Has previous been merged to the dev branch of Custobar/magento2-plugin, but due to the changes in the way of making changes to the repository during the process, will now make a proper description of the changes that originally have also gone out to the dev branch. Now just targeting master for the proper release.

In short the aim is to have the module support Magento version 2.4.6.

Major changes related to this:

  • Magento\Framework\HTTP\ZendClient has been dropped in 2.4.6, which has been used by this module. To still support 2.4.4 and 2.4.5 which still have the class available the usage has been refactored to support all of these three versions. Details about this can be checked from Model/CustobarApi/README.md
  • Support for Magento versions older than 2.4.4 has been dropped as 2.4.4 is the oldest officially supported version by Adobe. This means we could get rid of the deprecated InstallSchema and UpgradeSchema usages and replace these with the db_schema.xml definitions. This is technically a breaking change according to semantic versioning, so this is the main reason I updated the version in the README to be 3.0.0.

Minor changes added alongside this:

  • Brought test definitions up to date so that they can be run in the currently supported Magento test frameworks, for some reason this has been left out from earlier Magento version support changes
  • Fixed several code sniffer related warnings to make sure that catching actual errors is easier. For example, lack of comments, non scoped constants etc.
  • Fixed issue with order placement time not exporting with correct value to Custobar API
  • Fixed issue with sku resolving not always working Commerce edition due to the row_id and entity_id differences

How we have tested the changes on our side:

  • Integration tests have been run against clean installations of Magento 2.4.4, 2.4.5 and 2.4.6 and they all seem to pass
  • All Magento Functional Testing Framework tests listed here have been run against clean installations of Magento 2.4.4, 2.4.5 and 2.4.6 and they all seem to pass: https://developer.adobe.com/commerce/marketplace/guides/sellers/mftf-magento/
  • One of our internal QA engineers has checked module functionality and connections to Custobar API in Magento 2.4.6 environment and no issues were found

jooname added 12 commits June 12, 2023 11:21
…lier Magento versions, fixing and adjusting tests based on findings when run in 2.4.6 with some of the fixes relating to dropped Zend packages, fixing translation annotations
…ngs to help detect errors better, updated LICENSE file with correct year, updated composer.json to restrict installing the module to Magento 2.4.4 and newer, updated README, adding some general code styling and consistency fixes
…rative schema definition, since if the oldest version we want to support is 2.4.4 we can assume declarative schema is available for database related changes
…t turned out AddGroupedData needed also adjusting
… on 2.4.6 and newer since it appears there is some issue with running RefreshSpecialPrices cron in past versions, although this could be something specific to the test itself too
…adapter, since the default Magento one doesn't have handling for the associative array of headers that the Laminas client uses
@samipel
Copy link
Copy Markdown

samipel commented Jul 14, 2023

LGTM

@samipel samipel merged commit 5f8a858 into Custobar:master Jul 14, 2023
@jooname jooname deleted the feature/CUSTO-40-support-246 branch July 14, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants