Merged
Conversation
…lier Magento versions, fixing and adjusting tests based on findings when run in 2.4.6 with some of the fixes relating to dropped Zend packages, fixing translation annotations
…ngs to help detect errors better, updated LICENSE file with correct year, updated composer.json to restrict installing the module to Magento 2.4.4 and newer, updated README, adding some general code styling and consistency fixes
…rative schema definition, since if the oldest version we want to support is 2.4.4 we can assume declarative schema is available for database related changes
… 2.4.4 and 2.4.6 differences
…t turned out AddGroupedData needed also adjusting
… on 2.4.6 and newer since it appears there is some issue with running RefreshSpecialPrices cron in past versions, although this could be something specific to the test itself too
…adapter, since the default Magento one doesn't have handling for the associative array of headers that the Laminas client uses
Uninen
reviewed
Jul 14, 2023
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Has previous been merged to the dev branch of Custobar/magento2-plugin, but due to the changes in the way of making changes to the repository during the process, will now make a proper description of the changes that originally have also gone out to the dev branch. Now just targeting master for the proper release.
In short the aim is to have the module support Magento version 2.4.6.
Major changes related to this:
Minor changes added alongside this:
How we have tested the changes on our side: