Fix sendMessage bug#177
Merged
Ulexus merged 2 commits intoCyCoreSystems:mainfrom Feb 24, 2025
Merged
Conversation
Contributor
Author
|
@Ulexus сan you please tell me please, if it is enough to open a PR to contribute or I need to create an issue? |
Member
|
PR is fine; let me read through this. |
Ulexus
reviewed
Feb 20, 2025
Member
Ulexus
left a comment
Ulexus
left a comment
There was a problem hiding this comment.
Suggestion to tighten down empty interface use.
(Yes, I know the rest of this library makes copious use of empty interfaces, to my never ending annoyment... but I'd like to at least not continue the trend)
Ulexus
approved these changes
Feb 24, 2025
Member
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sendMessage endpoints expect an object in the body like {"variables": {...}}
https://docs.asterisk.org/Asterisk_18_Documentation/API_Documentation/Asterisk_REST_Interface/Endpoints_REST_API/#sendmessage
https://docs.asterisk.org/Asterisk_18_Documentation/API_Documentation/Asterisk_REST_Interface/Endpoints_REST_API/#sendmessagetoendpoint
This change is