Skip to content

Conversation

@emmanvg
Copy link
Contributor

@emmanvg emmanvg commented Feb 21, 2018

Created:

  • cybox.common.location.Location object
  • cybox.core.pool.Pools object (along with all its properties)
    • ActionPool
    • PropertyPool
    • ObjectPool
    • EventPool

Changed the generic add() method to also accept MeasureSource and Pools type objects.

@emmanvg
Copy link
Contributor Author

emmanvg commented Feb 28, 2018

Also, closes #310

Added tests for is_plain() and changed another to make sure the xsi:type was being serialized. This was affecting the to_dict() call

Copy link
Contributor

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gtback gtback merged commit d45ff7e into CybOXProject:master Feb 28, 2018
@gtback gtback added this to the v2.1.0.17 milestone Feb 28, 2018
@emmanvg emmanvg deleted the new-objs-implementation branch February 28, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants