fix: wrong way to write grub file #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was using echo to write grub file but it was a fatal flaw because echo overwriting the file by deleting other lines. So, I was changed that to grep to be able to keep other lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using echo to write grub file but it was a fatal flaw because echo overwriting the file by deleting other lines. So, I was changed that to grep to be able to keep other lines.
This pull request includes changes to improve the setup process in
setup.shand to correct a session name insrc/variables.sh. The most important changes include modifying the GRUB timeout configuration, updating LightDM settings, and correcting the session name.Improvements to setup process:
setup.sh: Changed the method for setting the GRUB timeout to 0 to ensure it only updates if not already set, preserving other lines in the configuration.setup.sh: Updated LightDM configuration to include additional autologin settings and improved comments for clarity.Correction of session name:
src/variables.sh: Corrected the session name from "Qtile" to "qtile" to match the expected case.