Skip to content

Comments

Add UnboundedRecordingSession#52

Merged
ruccho merged 11 commits intomainfrom
feature/unbounded_recording
Dec 22, 2025
Merged

Add UnboundedRecordingSession#52
ruccho merged 11 commits intomainfrom
feature/unbounded_recording

Conversation

@ruccho
Copy link
Collaborator

@ruccho ruccho commented Oct 10, 2025

Enables unbounded recording, which muxes encoded data and writes them into the disk on the fly.

On iOS, the muxer throws an exception after the app enters background due to AVAssetWriter's restriction. This can be a issue when using UnboundedRecordingSession because it runs the muxer during recording while RealtimeInstantReplaySession runs the muxer after the recording. I added onException delegate to UnboundedRecordingSession (and RealtimeInstantReplaySession) to make users possible to detect this error.

@ruccho ruccho linked an issue Oct 14, 2025 that may be closed by this pull request
Base automatically changed from feature/pipeline_abstraction to main October 15, 2025 05:14
@ruccho ruccho force-pushed the feature/unbounded_recording branch from c90a7af to d7b14fc Compare December 15, 2025 02:03
@ruccho ruccho changed the base branch from main to feature/zerocopy_android_vulkan December 15, 2025 02:04
@ruccho ruccho force-pushed the feature/unbounded_recording branch from d7b14fc to 5a95759 Compare December 15, 2025 02:05
Base automatically changed from feature/zerocopy_android_vulkan to main December 15, 2025 05:36
@ruccho ruccho marked this pull request as ready for review December 16, 2025 02:42
@ruccho ruccho requested review from hkmt-mmy and qua-iy December 16, 2025 02:42
README.ja.md Outdated

## 無制限録画

`UnboundedRecordingSession` を使用すると、エンコードしたデータをメモリに保持せず直接ディスク上の MP4 ファイルに書き出します。これによって時間の制限なしに録画が行えます。コンストラクタで出力ファイルパスの指定が必要な以外は `RealtimeInstantReplaySession` と同様に使用できます。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ディスクの容量という問題はあるのでは……?

容量が少なくなった場合にどういうことが起きるのかとか言及があったほうがいいかも?

@ruccho ruccho requested a review from hkmt-mmy December 22, 2025 01:21
@ruccho ruccho merged commit 7e21ac9 into main Dec 22, 2025
@ruccho ruccho deleted the feature/unbounded_recording branch December 22, 2025 07:33
@ruccho ruccho removed the request for review from qua-iy December 22, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

General unbounded recording

2 participants