adapt for multilingual #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to enhance support for multi-lingual document collections in the Qdrant handler and its associated tests. The updates include the addition of a multi-lingual collection code constant, modifications to collection naming logic, and new test cases to validate these changes.
Enhancements for Multi-Lingual Support:
welearn_datastack/constants.py: Added a new constantQDRANT_MULTI_LINGUAL_CODEto represent multi-lingual collections.welearn_datastack/modules/qdrant_handler.py: Updated theclassify_documents_per_collectionfunction to prioritize multi-lingual collection names usingQDRANT_MULTI_LINGUAL_CODE, with a fallback to language-specific collection names if the multi-lingual collection does not exist.Test Updates:
tests/qdrant_syncronizer/test_qdrant_handler.py:FakeSliceclass to accept a dynamicembedding_model_nameparameter and added a uniqueidattribute for better traceability.test_should_handle_multiple_slices_for_same_collection_with_multi_lingual_collectionto verify the behavior of the multi-lingual collection handling logic.Dependency Adjustments:
welearn_datastack/modules/qdrant_handler.py: Imported the newly added constantQDRANT_MULTI_LINGUAL_CODEfor use in collection naming logic.