fix: update document collection logic to use batch documents #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a data processing bug where all corpus plugins were incorrectly receiving the complete set of documents instead of their specific subset. The change ensures each corpus collector processes only its relevant documents, improving data handling accuracy.
Key Changes:
- Updated the document filtering logic to pass corpus-specific documents to each collector
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sandragjacinto
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the document collection logic in the
DocumentHubCollectorworkflow to ensure that each corpus plugin processes only its relevant documents. The main change improves data handling accuracy by passing the correct set of documents to each collector.Data extraction logic improvement:
corpus_collector.runindocument_collector.pyto usebatch_docs[corpus_name]instead ofwelearn_documents, ensuring each corpus processes only its own documents.