Add msn.com and xbox.com and mcas.ms to Microsoft domain allow-list in detection rules#129
Merged
KelvinTegelaar merged 3 commits intoCyberDrain:devfrom Mar 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds msn.com to the Microsoft domain allow-list in the phishing detection rules. MSN.com is a Microsoft-owned portal and web service, making it a legitimate addition to the microsoft_domain_patterns array to prevent false positives in phishing detection.
Changes:
- Added
msn.comdomain pattern to themicrosoft_domain_patternsarray in detection-rules.json
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Zacgoose <107489668+Zacgoose@users.noreply.github.com>
Zacgoose
changed the title
msn.com to Microsoft domain allow-list in detection rulesmsn.com and xbox.com to Microsoft domain allow-list in detection rules
Zacgoose
changed the title
msn.com and xbox.com to Microsoft domain allow-list in detection rulesmsn.com and xbox.com and 'mcas.ms' to Microsoft domain allow-list in detection rules
Zacgoose
changed the title
msn.com and xbox.com and 'mcas.ms' to Microsoft domain allow-list in detection rulesmsn.com and xbox.com and mcas.ms to Microsoft domain allow-list in detection rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.