Log warning on KeyError when linking illustration token to novel progress entry

[Copilot]

When a novel's progress entry is deleted mid-flight, progress_manager.update raises KeyError that was silently swallowed — leaving an orphaned image on disk with no way for the UI to surface it.

Changes

• novelforge/routes/export.py: Replace except KeyError: pass with a logger.warning that includes the missing progress token, making the failure observable in logs.

# Before
except KeyError:
    pass

# After
except KeyError:
    logger.warning(
        "Could not link illustration to novel (progress entry %s not found).",
        token,
    )

• tests/test_illustration_job.py: Add test_warning_logged_when_novel_progress_entry_missing — patches progress_manager.update to raise KeyError on the link call and asserts the warning is emitted via caplog.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• api.openai.com
  • Triggering command: /usr/bin/python python -m pytest --tb=short -q (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

This PR makes illustration-linking failures observable by logging a warning when the novel progress entry disappears (raising KeyError) during /generate_illustrations, and adds a regression test to ensure the warning is emitted.

Changes:

• Replace a silent except KeyError: pass with a logger.warning(...) in the illustration generation route.
• Add a pytest case that simulates progress_manager.update raising KeyError and asserts a warning is logged via caplog.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
novelforge/routes/export.py	Logs a warning when the novel progress entry is missing during illustration token linking.
tests/test_illustration_job.py	Adds a test to verify the warning is emitted when the linking update raises KeyError.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

caplog.records contains logging.LogRecord objects, which don’t reliably have a .message attribute populated. This can raise AttributeError or produce unformatted text depending on how pytest formats records. Prefer caplog.messages or record.getMessage() when building warning_msgs so the assertion is stable.

Suggested change

	warning_msgs = [r.message for r in caplog.records if r.levelno == logging.WARNING]
	warning_msgs = [r.getMessage() for r in caplog.records if r.levelno == logging.WARNING]