makefile: respect PREFIX, LIBDIR and DESTDIR

[FFY00]

This allows distributions to properly build packages.

Signed-off-by: Filipe Laíns lains@archlinux.org

[CyberShadow]

This is a breaking change, so I'm not sure about this. ZNC is most likely to be installed in /usr/bin.

I actually wrote the makefile for personal convenience. I'm not sure it should be in version control.

Perhaps use znc-buildmod directly and ignore the Makefile? This is what the AUR package does:
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=znc-clientbuffer-git

Probably this isn't the first third-party ZNC module packaged for Arch. What do other packages do?

[FFY00]

ZNC will be installed in /usr/bin if it was installed via the package manager. Manual installs to /usr are not supported by any distribution that I am aware of.

If that is the case you should install the plugins via your package manager. You can always just change PREFIX when running make if you really want to.

Perhaps we could make this clear in the readme?

Yes, this is the first packaged ZNC module.

[FFY00]

Running znc-buildmod directly is fine, but having the makefile doesn't really hurt, it makes things easier.

[CyberShadow]

ZNC will be installed in /usr/bin if it was installed via the package manager.

Yes, I think this is the most likely scenario from the point of view of someone running this makefile - install the distribution-provided ZNC package, and then additional third-party modules from source using znc-buildmod.

If that is the case you should install the plugins via your package manager. You can always just change PREFIX when running make if you really want to.

Maybe we can detect the prefix where ZNC (or znc-buildmod) is installed? Or, alternatively, it would be great if we could make the makefile fail if the PREFIX is incorrect. Removing the -D flag to install would do that, except in the case of a DESTDIR, so that's a dead end.

My concern is that, with this change, running sudo make install in the situation above will look like it worked but actually do the wrong thing in a way that I think may be difficult to diagnose for a good portion of this project's target audience.

What do you think?

Yes, this is the first packaged ZNC module.

Considering the Makefile was a "non-stardard" addition and znc-bulidmod is the expected way to build a ZNC module, I think using the latter would set a more universal precedent.

[FFY00]

We can run znc-buildmod from the prefix, $(PREFIX)/bin/znc-buildmod. This also makes sure we are building with the correct binary and avoids version errors, etc.

[CyberShadow]

Yes, excellent idea!

[CyberShadow]

Does this look OK to you?

[FFY00]

Sorry, had to hop on a quick call.

Yes, it looks good.

[CyberShadow]

Thanks! And also for packaging :)

[CyberShadow]

Tagged v1.0.48.