Skip to content

Provide additional Details for Webhook Operations#55

Merged
Cyclenerd merged 3 commits intoCyclenerd:masterfrom
hexa2k9:feature-return-runner-name-in-webhook-operations
Apr 28, 2026
Merged

Provide additional Details for Webhook Operations#55
Cyclenerd merged 3 commits intoCyclenerd:masterfrom
hexa2k9:feature-return-runner-name-in-webhook-operations

Conversation

@hexa2k9
Copy link
Copy Markdown
Contributor

@hexa2k9 hexa2k9 commented Mar 30, 2026

First off, thanks for taking the time to contribute!

Please Complete the Following

Notes

This will return the affected Runner Name in Webhook Operations and add the X-GitHub-Delivery Header to Logs to build a correlation between GitHub Webhook Requests and the Operations on Compute Engine.

We had some concurrency issues a little while ago and I needed to get additional Details from the Point that I wasn't able to identity which operations have been caused by which Webhook Delivery and which Webhooks haven't been delivered for which reason.

--

Example Response Payload (we use full length uuid v7 for runner names):

{"action":"deleted","runner_name":"runner-019d3e12-1434-75f8-8caa-6284eb790d05","status":"success"}

Which was logged in Cloud Run as the following:

2026-03-30 09:31:20,355 - app.routes.webhook - INFO - Received webhook event: workflow_job, delivery_id: 353f3530-2c1b-11f1-9b22-5695ca7b1ecb
[... additional log lines ...]
2026-03-30 09:31:20,704 - app.routes.webhook - INFO - Webhook processed successfully, action: deleted, runner_name: runner-019d3e12-1434-75f8-8caa-6284eb790d05, delivery_id: 353f3530-2c1b-11f1-9b22-5695ca7b1ecb

@hexa2k9 hexa2k9 marked this pull request as draft March 31, 2026 06:54
@hexa2k9 hexa2k9 marked this pull request as ready for review March 31, 2026 07:28
@hexa2k9
Copy link
Copy Markdown
Contributor Author

hexa2k9 commented Mar 31, 2026

If/once merged I'd like to refactor Logging to be "stackdriver compliant" which is currently undergoing in our private fork.

@Cyclenerd Cyclenerd merged commit e9a0580 into Cyclenerd:master Apr 28, 2026
4 checks passed
@Cyclenerd
Copy link
Copy Markdown
Owner

Thank you 👍 Sorry for the late merge. GitHub isn't reliably notifying me lately.

@hexa2k9
Copy link
Copy Markdown
Contributor Author

hexa2k9 commented Apr 28, 2026

Thank you 👍 Sorry for the late merge. GitHub isn't reliably notifying me lately.

No worries. Might take a while for the Cloud Logging PR to come too. It's complete on our end but I will have to carve this out of our Fork which is Go based with a Cloud Tasks backend for the heavy lifting meanwhile. We faced some issues with Workflows running with very high concurrency (90+ Jobs) and Flask didn't perform as good as I originally thought it would.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants