Skip to content

Conversation

@hiddedejong
Copy link
Contributor

@hiddedejong hiddedejong commented Jan 27, 2021

This PR makes some changes to reduce the number of CI minutes spent for every commit.

Release workflow
The existing CI workflow is renamed to Release and only runs when manually triggered. Previously, this workflow ran for every push and pull request on all branches.

Test workflow
The test workflow builds and runs the tests with debug and release configurations on macOS and Windows. Instead of running the debug and release configurations in parallel (like what the release workflow does), we run the builds in sequence. This saves an additional checkout and CMake project generation, and also ensures that the release build does not run if the more strict debug build fails.

The test workflow runs automatically on every push to master or develop, as well as every PR that wants to merge to one of these branches.

And finally, the latest Xcode is now used to build on macOS.

@robtherich
Copy link
Contributor

looks chef kiss great to me

Copy link
Contributor

@x37v x37v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@hiddedejong hiddedejong merged commit a3383b4 into master Jan 28, 2021
@hiddedejong hiddedejong deleted the actions branch January 28, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants