chore: add zizmor workflow to harden GitHub Actions security#968
chore: add zizmor workflow to harden GitHub Actions security#968
Conversation
Up to standards ✅🟢 Issues
|
Agent-Logs-Url: https://github.com/CycloneDX/cyclonedx-python-lib/sessions/f5512c78-6b6d-46ca-adf5-4cf6045187b0 Co-authored-by: jkowalleck <2765863+jkowalleck@users.noreply.github.com>
…flow Agent-Logs-Url: https://github.com/CycloneDX/cyclonedx-python-lib/sessions/b5733fc7-3e3a-4c62-a94c-54620cce9147 Co-authored-by: jkowalleck <2765863+jkowalleck@users.noreply.github.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
|
did originally instruct Copilot not to fix any findsings from zizmor, so show that the workflow is usable and actually detects the things i already know.
workflow is running, and working as expected. |
|
@copilot create a new branch from here, and have all those findings from zizmor fixed. |
|
@jkowalleck I've opened a new pull request, #969, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@copilot use the repositories own pull request template in the PR descrioption. |
I don't have a tool available to directly edit the description of PR #969 from this session. Here is the description formatted with the repository's PR template that should be applied to PR #969: DescriptionResolves all warnings and notices surfaced by the zizmor CI audit run across
Resolves or fixes issue: none AI Tool Disclosure
Affirmation
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Could just paste https://github.com/jazzband/pip-tools/blob/6be966f0c1677bdf5a49f7a8d46544f7208353b0/.github/workflows/ci.yml#L532-L538 into the main workflow 🤷♂️
There was a problem hiding this comment.
Also, additionally integrate Zizmor into the pre-commit framework config
Description
Resolves all warnings and notices surfaced by the zizmor CI audit run across
dependabot.yml,python.yml, andrelease.yml.dependabot.yml— Addedcooldown.default-days: 7to bothpipandgithub-actionsupdate entries to satisfy zizmor's insufficient-cooldown audit.python.yml— Addedpersist-credentials: falseto all 7actions/checkoutsteps; prevents the checkout token from being stored in the local git config and potentially leaking via artifacts.release.yml— Samepersist-credentials: falsefix on all 3 checkout steps. Additionally fixed a code injection via template expansion:${{ steps.release-bot-token.outputs.app-slug }}was interpolated directly into arunscript; moved to anenvvariable instead.Resolves or fixes issue: none
AI Tool Disclosure
GitHub CopilotClaude Sonnet 4Fix all zizmor security findings surfaced in PR #968 across dependabot.yml, python.yml, and release.ymlAffirmation