Skip to content

[WIP] Fix crash reports for neoforge and other mod loaders#225

Closed
Copilot wants to merge 1 commit intomaster-26from
copilot/fix-crash-reports
Closed

[WIP] Fix crash reports for neoforge and other mod loaders#225
Copilot wants to merge 1 commit intomaster-26from
copilot/fix-crash-reports

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026

  • Fix View description and current value of config value when using command #1: Add null player safety check to PacketHandlerNeoForge.handlePacketClient() (matches the fix described in 1.20.1 CHANGELOG: "Add client-side null player safety check to PacketHandler, Closes NPE fix for 1.20.1 #211")
  • Fix Add xml recipe wiki page #2: Add try-catch around packet handling in PacketHandlerNeoForge to prevent uncaught network errors from crashing (matches the fix described in CHANGELOG: "Fix network errors not being caught by PacketHandler")
  • Apply the same fixes to PacketHandlerFabric for other mod loaders
  • Build and verify fixes compile correctly
Original prompt

There are two crash reports on neoforge (may also occur in other mod loadets), but I'm not sure if the two are related. Can you fix them?

https://gist.github.com/MichaelHillcox/5248fd4ba198e32fdddb060c9390de64

https://gist.github.com/MichaelHillcox/a1237670283c5c4414c7c20d46b50c38

@sonarqubecloud
Copy link
Copy Markdown

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 30.848%. remained the same — copilot/fix-crash-reports into master-26

Copilot stopped work on behalf of rubensworks due to an error April 11, 2026 17:04
Copilot AI requested a review from rubensworks April 11, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPE fix for 1.20.1 Add xml recipe wiki page View description and current value of config value when using command

3 participants