Add configurable pulse length property to Redstone Writer#1602
Merged
rubensworks merged 6 commits intomaster-1.21-ltsfrom Feb 15, 2026
Merged
Add configurable pulse length property to Redstone Writer#1602rubensworks merged 6 commits intomaster-1.21-ltsfrom
rubensworks merged 6 commits intomaster-1.21-ltsfrom
Conversation
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Pulse Length Option to Redstone Writer
Add configurable pulse length property to Redstone Writer
Feb 15, 2026
rubensworks
requested changes
Feb 15, 2026
Member
rubensworks
left a comment
There was a problem hiding this comment.
Could you also add some game tests for this new feature?
Also, logs/latest.log should not be pushed.
|
|
||
| PROPERTIES_REDSTONE_PULSE.setValue(PROP_STRONG_POWER, ValueTypeBoolean.ValueBoolean.of(false)); | ||
| PROPERTIES_REDSTONE_PULSE.setValue(PROP_PULSE_EMIT_VALUE, ValueTypeInteger.ValueInteger.of(15)); | ||
| PROPERTIES_REDSTONE_PULSE.setValue(PROP_PULSE_LENGTH, ValueTypeInteger.ValueInteger.of(2)); |
Member
There was a problem hiding this comment.
Default pulse value should be 1.
Contributor
Author
There was a problem hiding this comment.
Done in commit 95078a8. Changed the default pulse length from 2 to 1 tick to maintain original behavior.
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Contributor
Author
Done in commit 95078a8. Added two game tests:
Also removed Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "Pulse Length" AspectProperty to configure redstone pulse duration in ticks. Previously, pulses lasted until the next aspect evaluation (timing-dependent). Now pulses have deterministic tick-based duration.
Changes
New AspectProperty:
PROP_PULSE_LENGTH(integer, ≥1 tick, default 1)PROPERTIES_REDSTONE_PULSEen_us.jsonPulse scheduling infrastructure:
IDynamicRedstonewithsetScheduledPulseRemaining(int)/getScheduledPulseRemaining()scheduledPulseRemainingmap toBlockEntityMultipartTickingupdateScheduledPulses()Updated pulse logic in
PROP_SET_PULSE:Game tests: Added two tests to verify configurable pulse length functionality:
testAspectsWriteRedstoneBooleanPulseLengthLong: Tests 10-tick boolean pulse durationtestAspectsWriteRedstoneIntegerPulseLengthLong: Tests 10-tick integer pulse durationDefault of 1 tick maintains original behavior. Users can configure longer pulse durations as needed.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.