Skip to content

Add configurable energy production rate for coal generator#1635

Merged
rubensworks merged 2 commits intomaster-1.19-ltsfrom
copilot/add-config-option-generation-rate
Mar 28, 2026
Merged

Add configurable energy production rate for coal generator#1635
rubensworks merged 2 commits intomaster-1.19-ltsfrom
copilot/add-config-option-generation-rate

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

The coal generator's energy output was hardcoded at 20 RF/t with no way to adjust it via config.

Changes

  • BlockEntityCoalGeneratorConfig: Added a @ConfigurableProperty server-side config field energyPerTick (default: 20, min: 1, category: machine)
  • BlockEntityCoalGenerator: Replaced both usages of the ENERGY_PER_TICK constant in Ticker.update() with BlockEntityCoalGeneratorConfig.energyPerTick
@ConfigurableProperty(category = "machine", comment = "The energy production rate (in RF/t) of the coal generator.", minimalValue = 1, configLocation = ModConfig.Type.SERVER)
public static int energyPerTick = 20;
Original prompt

This section details on the original issue you should resolve

<issue_title>Generator needs to have a way for us to increase the generation rate in the config. [Static value at 20 RF/t]</issue_title>
<issue_description>

Issue type:

  • ➕ Feature request

Short description:

We need the ability to change the generation rate for the generator, currently the generator seems to be hardcoded at 20 RF/t</issue_description>

<agent_instructions>Could you add a config option for this in https://github.com/CyclopsMC/IntegratedDynamics/blob/master-1.21-lts/src/main/java/org/cyclops/integrateddynamics/blockentity/BlockEntityCoalGeneratorConfig.java ?
This is the current static field: https://github.com/CyclopsMC/IntegratedDynamics/blob/master-1.21-lts/src/main/java/org/cyclops/integrateddynamics/blockentity/BlockEntityCoalGenerator.java#L45
And usages should be replaced by this config option.
And make a PR.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@rubensworks

Thanks for the suggestion!


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 24, 2026

Coverage Status

coverage: 16.007% (-0.001%) from 16.008%
when pulling 72a65ac on copilot/add-config-option-generation-rate
into 53decab on master-1.19-lts.

@rubensworks rubensworks moved this to To Do in Maintenance Mar 24, 2026
Copilot AI changed the title [WIP] Add config option to increase generator generation rate Add configurable energy production rate for coal generator Mar 24, 2026
Copilot AI requested a review from rubensworks March 24, 2026 06:59
@rubensworks rubensworks marked this pull request as ready for review March 24, 2026 07:08
@rubensworks rubensworks merged commit fd77459 into master-1.19-lts Mar 28, 2026
5 checks passed
@rubensworks rubensworks moved this from To Do to Done in Maintenance Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants