Skip to content

Fix terminal crash: replace removed CyclopsCore drawSlotText with inlined rendering logic#198

Closed
Copilot wants to merge 2 commits intomaster-26from
copilot/fix-terminal-crash-issue
Closed

Fix terminal crash: replace removed CyclopsCore drawSlotText with inlined rendering logic#198
Copilot wants to merge 2 commits intomaster-26from
copilot/fix-terminal-crash-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 12, 2026

GuiGraphicsExtended.drawSlotText(Font, String, int, int) was removed in CyclopsCore 1.29.0, causing a NoSuchMethodError at runtime for users running newer CyclopsCore against older IntegratedTerminals builds.

Changes

  • gradle.properties: Bump cyclopscore_version 1.25.5-9741.29.0-984
  • IngredientComponentTerminalStorageHandlerEnergyClient, IngredientComponentTerminalStorageHandlerFluidStackClient, TerminalStorageSlotIngredientCraftingOption: Replace GuiGraphicsExtended.drawSlotText(...) calls with inlined equivalent using GuiGraphicsExtractor directly, and drop the now-unused GuiGraphicsExtended imports

The inlined rendering is a direct equivalent of the removed method — 0.5× scale, right-aligned text at the slot's bottom-right corner:

// Before (removed from CyclopsCore 1.29.0)
new GuiGraphicsExtended(guiGraphics).drawSlotText(font, label, x, y);

// After (inlined)
float scale = 0.5f;
guiGraphics.pose().pushMatrix();
guiGraphics.pose().scale(scale, scale);
guiGraphics.text(font, label, (int) ((x + 17) / scale - font.width(label)), (int) ((y + 12) / scale), -1, true);
guiGraphics.pose().popMatrix();

Copilot AI linked an issue Apr 12, 2026 that may be closed by this pull request
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 12, 2026

Coverage Report for CI Build 24300276272

Coverage decreased (-0.02%) to 8.624%

Details

  • Coverage decreased (-0.02%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 34 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

34 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
org/cyclops/integratedterminals/capability/ingredient/IngredientComponentTerminalStorageHandlerEnergyClient.java 13 0.0%
org/cyclops/integratedterminals/capability/ingredient/IngredientComponentTerminalStorageHandlerFluidStackClient.java 11 0.0%
org/cyclops/integratedterminals/core/terminalstorage/slot/TerminalStorageSlotIngredientCraftingOption.java 10 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 5538
Covered Lines: 591
Line Coverage: 10.67%
Relevant Branches: 1732
Covered Branches: 36
Branch Coverage: 2.08%
Branches in Coverage %: Yes
Coverage Strength: 0.48 hits per line

💛 - Coveralls

…lined GuiGraphicsExtractor calls

Agent-Logs-Url: https://github.com/CyclopsMC/IntegratedTerminals/sessions/9cc5d25d-d22a-49c1-a9ee-2fcd472e5264

Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix crash when opening terminal Fix terminal crash: replace removed CyclopsCore drawSlotText with inlined rendering logic Apr 12, 2026
Copilot AI requested a review from rubensworks April 12, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when opening terminal

3 participants