Skip to content

Conversation

@MarcScheib
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@MarcScheib MarcScheib requested a review from Copilot April 26, 2025 11:31
@MarcScheib MarcScheib linked an issue Apr 26, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for OS-specific steps and refactors configuration handling by removing the WorkspaceConfig dependency in favor of a simpler Config interface. Key changes include:

  • Removal of the WorkspaceConfig parameter from UseCaseRunner, ContextCreator, and RepositoriesRepository.
  • Updates in TemplatesAccess to use a new Config interface and adjustment of repository URL creation.
  • Changes to configuration loading and command modules (sync, run, init) to ensure proper config extraction and the introduction of a debug option.

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/services/use-cases/use-case-runner.ts Removed config parameter; updated ContextCreator creation method.
src/services/use-cases/context-creator.ts Updated create method signature and added OS property to context.
src/services/repositories.repository.ts Removed config parameter and updated repository URL creation.
src/services/access/templates-access.ts Changed to use Config interface; updated property access accordingly.
src/config.ts Refactored config loading to return a plain config store in certain cases.
src/commands/sync/sync.ts Updated call to UseCaseRunner.create to match new parameter signature.
src/commands/run/run.ts Added debug option and adjusted config loading accordingly.
src/commands/init/action.ts Updated config usage with config.store for TemplatesAccess creation.
README.md Updated documentation to add the new debug option and OS property.
Files not reviewed (1)
  • assets/templates/config/use-cases/check-requirements.json: Language not supported
Comments suppressed due to low confidence (2)

src/config.ts:74

  • The function loadWorkspaceConfig now returns config.store instead of the full Conf instance. Please ensure that all consuming modules correctly handle the change to a plain config object to avoid type mismatches.
return loadConfig(workspacePath).store;

src/commands/init/action.ts:68

  • The usage of config.store here differs from other commands (where a plain config object is already expected). Please verify that converting the Conf instance to a plain object in init aligns with the overall configuration handling strategy.
const templatesAccess = TemplatesAccess.create(config.store);

@MarcScheib MarcScheib force-pushed the 3-add-support-for-os-specific-steps branch from 3b6a5ab to 56edf51 Compare April 26, 2025 11:35
@MarcScheib MarcScheib merged commit b99844d into develop Apr 26, 2025
1 check passed
@MarcScheib MarcScheib deleted the 3-add-support-for-os-specific-steps branch April 26, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for OS specific steps

2 participants