This repository was archived by the owner on Apr 6, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 561
Change the network module of cpp-redis #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #29, some issues have been reported concerning cpp_redis.
Most of these issues are related to the network side of cpp_redis.
Instead of constantly fixing issues on that side, I decided to rewrite the network module as I was not satisfied with the current implementation (not satisfied by the design, maintainability was reduced over time and so on).
I decided to develop a TCP network library, Tacopie with an enhanced design and aiming to fix all the current issues (#38, #29, #24, #21, #19).
The current network module has been entirely removed.
Instead, tacopie has been integrated as a submodule of cpp_redis and is the new network part of the library.
The advantages of the submodule are the following:
Another main advantage is that the network part may be changed for another library.
For now, tacopie is a pre-requisite of cpp_redis.
But in future versions, tacopie will become optional (packaged by default) and if the developer wants to integrate another network library, he will be able to (for example, Boost Asio).
There is no change in terms of features: library still provides the same features and work on both windows and Unix based platforms.
This constitutes a new release: v3.0.0.
Issues #38, #29, #24, #21, #19 will be closed as not relevant anymore.
If new problems are detected, please open new issues.
Objectives for next releases are:
Enjoy!