Added Activate Overlay + AppID expression + is initialized #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks a lot for your submission! I see some of the code has been reformatted. Could you please keep the original format if possible. That would make the review easier 🙏 |
Contributor
Author
|
Ah sorry! i have an auto formatter, I will try to revert the formatting if I can |
Contributor
Author
|
Ok my b check again now @Armaldio |
Contributor
Author
|
Exposed _isInitialized as it's useful for cross platform support (i.e. game that runs on the web and game that runs on a platform with pipelab) |
skymen
changed the title
Member
|
Can you give permission to edit the pull request ? |
Contributor
Author
|
Added you to the repo @Armaldio |
Member
|
Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly AI generated but through testing it works, and reading the code in context it seems to make a lot of sense.
Let me know if this is good enough :)