Hdf5#783
Conversation
…ethods: to_binary(std::ostream) and from_binary(std::istream) Clearer separation: Save and Load handle file IO, while to_binary and from_binary only write to ostream or istream implementation classes provide to_binary_dispatch(std::ostream) and from_binary_dispatch(std::istream)
…ectly because the char* is not terminated by \0. Potentially illegal memory access
…use they cannot be used in python directly
…th instead of string for file names
implemented Save/Load with path for UniTensor and MPS (but to/from_hdf5 still missing) H5 output is currently disabled for using try-catch statements without output to std::err
…F5 1.10.0 or newer
added const attribute to operator+-*/% for Tensor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81d4c5358d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4242b9996a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec5b97f4db
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
The API uses the existing Save and Load methods for HDF5 files. Feel free to comment on the APIs and the data format |
manuschneider
force-pushed
the
hdf5
branch
6 times, most recently
from
7765473 to
efff52c
Compare
this simplifies and unifies from_hdf5 load functions significantly
|
I will take this PR with milestone v1.2.0. |
2 participants
Implements HDF5 support for saving and loading