Fix: call islands lingering, permanent island flicker, and system cr#201
Merged
Conversation
…shes - Fixed an issue where call islands would persist after the call ended by explicitly dismissing `NotificationType.CALL` islands when their original notification is removed. - Fixed system crashes and flicker caused by rapid notification updates by using standard `.notify()` instead of `.notifyWithCancel()` when updating standard notifications. - Fixed an issue in `PermanentIslandManager` that caused the permanent island to flicker indefinitely. State updates and dispatches are now only triggered when the `isPermanentIslandEnabled` flag or `currentWidth` actually change. - Added the "Dismiss with original" setting to the `OnboardingScreen` so users can configure it during initial setup. - Reduced the visual gap between the "Remove original notification" and "Dismiss with original" toggle cards in the settings menu. - Changed the "Live updates" section title in settings to "Original notification behavior" (and corresponding Spanish translation) as these options control general notification behavior, not just Live Updates. - Added Spanish translations for the new "Dismiss with original" feature strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…shes
NotificationType.CALLislands when their original notification is removed..notify()instead of.notifyWithCancel()when updating standard notifications.PermanentIslandManagerthat caused the permanent island to flicker indefinitely. State updates and dispatches are now only triggered when theisPermanentIslandEnabledflag orcurrentWidthactually change.OnboardingScreenso users can configure it during initial setup.