Skip to content

Conversation

@amzhao16
Copy link
Collaborator

Cleaning/linting branch

  • updating imports to be in line with ruff linter
  • updating docstrings to be consistent with past code changes
  • removing unnecessary TODOs

@amzhao16 amzhao16 requested a review from sarahmish March 21, 2025 19:06
@amzhao16 amzhao16 changed the base branch from main to angela-branch March 22, 2025 04:41
Copy link
Contributor

@sarahmish sarahmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @amzhao16! This branch can be merged!

__version__ = '0.1.0.0'

from pygridsim.core import PyGridSim
from pygridsim.core import PyGridSim as PyGridSim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious as why this change is needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was recommended by ruff linter: Use an explicit re-export: PyGridSim as PyGridSim

@amzhao16 amzhao16 merged commit f1c5034 into angela-branch Mar 22, 2025
@amzhao16 amzhao16 self-assigned this Apr 28, 2025
@amzhao16 amzhao16 added the bug Something isn't working label Apr 28, 2025
@amzhao16 amzhao16 added this to the 0.1.0 milestone Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants