-
Notifications
You must be signed in to change notification settings - Fork 2
Update master from develop #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* #376: rework import structure and improve code quality #376: include python3.9 setup and add lbaf to requirements in editable mode #376: add .egg-info files to gitognore #376: add run configuration for vscode to help debugging in vscode #376: refactor and clean code #376: refactor fix tests imports #376: remove unnecessary statements #376: refactor and updates #376: update package config and clean import statements #376: fix module init #376: fix previous introduced error in rank_object_enumerator #376: fix quotes #376: add missing dependency to matplotlib in setup.cfg and refactoring #376: fix pylint warnings #376: change quotes #376: fix trailing white space and quotes #376: rename LBAF back to LBAF_app #376: restore acceptance tests with python 3.9 #376: try fix libxrender error with python3.9 #376: try fix stepper test in python 3.9 #376: rename project_dir to project_path for consistency #376: refactor #376: fix logger issue #376: fix bad argument #376: update pylint pragmas #376: update import of SchemaValidator #376: fix lazy import of schema validator #376: fix conflicts for merging branch * #376: remove unused files * #376: remove unused common.py module * #376: fix function defined twice * #376: fix merge issues and pytlint errors
* #355: add vt writer unit test for a null test * #355: sort keys in vt writer null test output * #355: add schema validator and update configuration file * #355: enable test to ignore some keys and ordering * #355: use PhaseStepper algorithm and auto-detect of schema optional keys to ignore * #355: fix migratable value output in VTDataWriter * #355: try fix possible missing package for github actions * #355: try fix root access on gh action * #355: try fix XServer issue on Gh Actions * #355: another try with XServer * #355: try add DISPLAY env var for gh actions * #355: try again x-server fix * #355: try another xvfb port * #355: remove LBAF_Viz from config for gh actions to not require x server * #355: clean code and add code comments * #355: fix missing empty line * #355: fix missing empty line * #355: update some comment * #355: sort .gitignore lines * #355: update comment
* #347: remove theme option and refactor logging module and LBAF_app * #347: raise error if save_meshes is True in a python 3.9 execution environment * #347: remove color formatting in logger if not console logger * #387: move error raising on save_meshes to the Visualizer class * #387: add VSCode run configuration for Python 3.9 * #347: improve configuration upgrader to support keeping comments defined at top of config file & add bool representer * #347: remove terminal_background option using the configuration_upgrader * #347: remove terminal_background option from configuration schema and from docs * #347: logging module refactoring and add comments * #347: fix bad variable * #347: fix issue in upgrader and restore and update conf.yaml comments * #347: fix trailing whitespace * #347: update conf.yaml docs * #347: upgrade docs for conf.yaml * #347: upgrade docs for conf.yaml * #347: upgrade docs for conf.yaml * #347: use single quotes for single characters throughout entire code base * #347: add colon before starting itemization in docstring * #347: fix typo and quotes in a yaml file
* #353: display error on invalid object_qoi or rank_qoi value * #353: automatic set n_ranks in the LoadReader * #353: Fix conflict with yaml files * #353: Fix conflict in 1 file * #353: LoadReader autodetection of n_ranks and update LoadReader constructor * #353: improve code quality * #353: remove trailing whitespace * #353: remove n_ranks remaining in some configuration files * #353: fixbug with acceptance tests * #353: remove remaining n_ranks refs in rst files * #353: remove remaining n_ranks refs in rst files * #353: add missing n_ranks key to the test configurations using from_samplers * #353: add missing n_ranks key to the another test configuration using from_samplers
…ete the rest (#398) * #386: upgrade rank_object_enumerator script to work * #386: move used function of rank_object_enumerator to lbsStatistsics module and deprecate rank_object_enumerator * #386: update LBAFApp to work with functions moved to lbsStatistics * #386: update some test brute force config file * #386: fix error in brute BruteForceAlgorithm class * #386: add some bruteforce run configuration for VS code * #386: update VSCode launch configuration * #386: fix problem with refactoring and acceptance tests * #386: remove n_ranks no more valid attribute * #386: fix issue in LBAF_App with n_ranks * #386: fix potential BruteForce invalid phases key * #386: eliminate duplicated code in BruteForceAlgorithm and LBAF_App + use loaded `Object` instances instead of dictionaries * #386: simplify method call * #386: fix bad variable name * #386: set pylint to fail only on error or with score lower that 8.5 * #386: refactor the BruteForce algorithm to exclude duplicated code * #386: refactor and remove duplicated code * #386: improve code quality * #386: improvement in compute_arrangement_works * #386: improve some code * #386: review docstrings with PEP257 in lbaf module and move useful function to lbsStatistics * #386: fix trailing whitespace
…and line (#400) * #396: fix conflicts and make 2 modules callable * #396: fix logger module import * #396: reorganize imports in 2 modules * #396: remove unused file * #396: fix some invalid import * #396: fix bad import * #396: enable to run upgrade_configuration to only reformat a configuration file * #396: remove trailing whitespace
* #368: move stepper tests and acceptance tests to the unittest tests to include in tox * #368: update gitignore * #368: update CI workflow * #368: update CI workflow * #368: update gitignore * #368: rename acceptance to synthetic-acceptance * #386: refactor * #368: rename workflow * #368: fix call error * #368: fix bug in a test * #368: fix bad config path for a test * #368: rename workflow * #368: upgrade tox and colorama dependency versions * #368: create a single requirements.txt file * #368: upgrade colorama version also for lbaf package setup * #368: refactor and simlify tox.ini * #368: rename workflow * #368: remove method duplicate * #368: pylint fixes * #368: pylint fixes * #368: disable some unexpected pylint warnings * #368: remove unnecessary line * #368: tentative to display unit tests results better * #368: keep only one requirements file and try fix Test report action * #368: try another Test report plugin * #368: fix issue with test output * #368: rename tests report * #368: try again another plugin * #368: upgrade version of test report plugin * #368: setoption to report output on CI * #368: fix remaining quotes and warnings * #368: fix pylint notice messages
* #388: Add verbosity level argument to lbaf.app (in progress) * #388: add command line option to print list of implemented QOI * #388: add default verbosity level * #388: print all possible QOI * #388: move verbosity argument within printing function * #388: alter formatting of output * #388: simplify for loop * #388: update --help message, fix typo * #388: more formatting changes to output list * #388: print list as part of error for invalid QOI * #323: add work to r_qoi_list
* #379: create an ApplicationBase class and integrate interactive mode and refactor * #379: fix issue with cli argument * #379: refactor make 3 applications working with common AppicationBase parent class * #379: continue refactoring * #379: wip on refactoring * #379: add args option to Applciation run method to not use argument parser and fix bugs * #379: replace ApplicationBase by RunnerBase in Utils and much refactoring for it * #379: continue refactoring and rename modules * #379: fix pylint messages * #379: fix names * #379: fix DataStatsFileUpdater and RunnerBase type support * #379: refactor introduce PromptArgParser for utilities and apps using cli to remove RunnerBase and sort imports * #379: put except_hook only on script or application startup and rename scripts with lbs prefix * #379: fix unit test due to exception class changed * #379: logger parameter name consistency * #379: formatting * #379: refactor exception handler and introduce TerseError class * #379: fix unit test error * #379: fix pylint error and warnings * #379: fix trailing whitespace * #79: fix unit tests * #379: restore names only for applications as in develop * #379: fix issue in VT Validator Loader * #379: update README with new console commands from lbaf package * #379: update README * #379: update README * #379: remove exception handler and clean code
* #323: moved all messaging logic to inform and transfer algo * #323: separated out load information * #323: simplified code by makings "targets" a set instead of dict * #323: added "estimate" method to criteria for non-local information (distributed) * #323: Fix whitespace error * #323: Update tests to reflect changes in Rank * #323: create test for InformAndTransferAlgorithm * #323: progress update (refactored messages now processed and relayed) * #323: fixed debug statement * #323: fixed initial spawning and aggregation of initial messages * #323: completed refactoring of information stage * #323: made transfer algorithms work again with refactored information * #323: fixed test errors * #323: removed useless header comments * #323: displaced CMF calculation where it belongs * #323: fix unit tests to reflect changes in lbsMessage and lbsRank * #323: finalize InformAndTransfer testing and fix typos in Rank --------- Co-authored-by: Caleb Schilly <cwschilly@gmail.com>
* #324: memory: implement centralized memory-constrained algorithm * #324: removed unused import * #324: Phase not used by centralized algo * #324: reorganized constructor * #324: deleted confusing (and incorrect) control flow log --------- Co-authored-by: Philippe P. Pébaÿ <philippe.pebay@ng-analytics.com>
* #414: resolved inconsistencies in treatment of average load between strategies * #414: entire rework of the rank/target selection process * #414: refactoring and factoring out of CMF-based selection of target * #414: completed rework of transfer/reject logic and reporting thereof * #414: simplification of recursive flow * #414: doc * #414: whitespace cleanup * #414: fixed trailing WS and docstring Signed-off-by: Philippe P. Pébaÿ <philippe.pebay@ng-analytics.com> * #414: allow for deteministic rank order * #414: PR fixed and added cluster randomization --------- Signed-off-by: Philippe P. Pébaÿ <philippe.pebay@ng-analytics.com>
…ronment (#425) * #376: make lbaf runnable with multiple lbaf versions * #376: make tests use lbaf source instead of lbaf package * #376: make the 6 runnable scripts load lbaf module if package not found * #376: update README * #376: update README and remove default lbaf package install from requirements.txt * #376: remove trailing whitespaces in REAME.md * #376: remove unnecessary import * #376: fix lbaf module path
* #428: allowing swaps of empty clusters from target * #428: testing clustering strategy and showing max memory * #428: allow empty clusters on source; and better printouts * #428: Skip trivial swaps and provide better information printouts * #428: changed execution logic to allow only one target for swaps; also randomization * #428: further improved execution speed and printouts * #428: removed leftover debug code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.