Skip to content

add more details about making a release#688

Merged
d-chambers merged 2 commits into
masterfrom
add-release-docs
May 22, 2026
Merged

add more details about making a release#688
d-chambers merged 2 commits into
masterfrom
add-release-docs

Conversation

@d-chambers
Copy link
Copy Markdown
Contributor

@d-chambers d-chambers commented May 22, 2026

Description

This PR adds more details about making a DASCore release. It is purely a documentation update.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings and/or appropriate doc page.
  • included tests. See testing guidelines.
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

Summary by CodeRabbit

  • Documentation
    • Updated development workflow guidelines for task management and worktree path specifications
    • Expanded release publishing documentation with structured changelog formatting requirements (New Features/Bug Fixes/Breaking Changes), pre-release checks, and package/docs verification procedures
    • Refined Conda-forge integration workflow guidance

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

Warning

Rate limit exceeded

@d-chambers has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 36 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a3f6b5cd-0e44-419f-941d-a23930736566

📥 Commits

Reviewing files that changed from the base of the PR and between 6da4296 and 8661b76.

📒 Files selected for processing (2)
  • .github/workflows/build_deploy_stable_docs.yaml
  • docs/contributing/publish_a_new_release.qmd
📝 Walkthrough

Walkthrough

This PR standardizes agent task worktree paths to {repo_root}/worktrees/{slug} across development workflow documentation and skill implementation, and comprehensively rewrites the release procedure guide with preflight checks, structured changelog requirements, post-publish validation, and updated Conda-forge integration steps.

Changes

Worktree Path Standardization

Layer / File(s) Summary
Development workflow checklist update
.agents/agents.md
Agent development workflow checklist updated to instruct creation of task worktrees at worktrees/{slug} instead of .agents/worktrees, with subsequent checklist items renumbered accordingly.
Start task skill path enforcement
.agents/skills/start_task/SKILL.md
Start task skill implementation tightened to require fully qualified {repo_root}/worktrees/{slug} path with a preflight verification step confirming the resolved target path before invoking git worktree add. Notes section updated to consistently reference {repo_root}/worktrees/.

Release Procedure Documentation

Layer / File(s) Summary
Release workflow guide
docs/contributing/publish_a_new_release.qmd
Release procedure expanded from a 3-step outline to a comprehensive maintainer workflow: added doc-build verification before releasing, clarified git tag selection per versioning policy, structured release notes into grouped changelog (New Features/Bug Fixes/Breaking Changes) with auto-generated text review guidance, added post-publish validation checklist covering GitHub Actions and PyPI/docs outcomes, and rewrote Conda-forge feedstock process to wait for PyPI release, request version updates via issue or bot commands, and verify dependency changes against pyproject.toml.

Possibly related PRs

  • DASDAE/dascore#683: Both PRs update the agent start-task workflow to enforce {repo_root}/worktrees/{slug} as the git worktree location and adjust .agents/agents.md guidance accordingly.
  • DASDAE/dascore#630: Both PRs modify .agents/skills/start_task/SKILL.md around git worktree paths and preflight expectations.
  • DASDAE/dascore#613: Both PRs modify agent workflow documentation in .agents/agents.md.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change—adding more details about making a release—which aligns with the three files modified (agents.md, SKILL.md, and publish_a_new_release.qmd).
Description check ✅ Passed The PR description follows the template structure with a Description section explaining the update and a completed Checklist, though no GitHub issue was referenced as indicated by the unchecked checkbox.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-release-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
docs/contributing/publish_a_new_release.qmd (1)

36-38: ⚡ Quick win

Add canonical conda-forge bot-command reference (“@conda-forge-admin, please update version”) to prevent doc drift

In docs/contributing/publish_a_new_release.qmd (lines 36-38), add a link to conda-forge’s official documentation that defines the exact bot-trigger issue title: https://conda-forge.org/docs/maintainer/infrastructure/ (optionally also https://conda-forge.org/docs/maintainer/updating_pkgs/).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/contributing/publish_a_new_release.qmd` around lines 36 - 38, Update the
paragraph that mentions the bot command by replacing or augmenting the plain
text "`@conda-forge-admin`, please update version" with a canonical reference to
conda-forge documentation: link that phrase to
https://conda-forge.org/docs/maintainer/infrastructure/ (and optionally also add
https://conda-forge.org/docs/maintainer/updating_pkgs/), so readers can click
the exact bot-command guidance; locate the string "`@conda-forge-admin`, please
update version" in publish_a_new_release.qmd and add the links inline near that
sentence.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/contributing/publish_a_new_release.qmd`:
- Line 21: Replace the incorrect phrase "includes and agent skill" with
"includes an agent skill" in the sentence that reads "Also note, DASCore
includes and agent skill called "draft release"" so the guidance reads
"...DASCore includes an agent skill called "draft release"..." to fix the
grammar typo.

---

Nitpick comments:
In `@docs/contributing/publish_a_new_release.qmd`:
- Around line 36-38: Update the paragraph that mentions the bot command by
replacing or augmenting the plain text "`@conda-forge-admin`, please update
version" with a canonical reference to conda-forge documentation: link that
phrase to https://conda-forge.org/docs/maintainer/infrastructure/ (and
optionally also add https://conda-forge.org/docs/maintainer/updating_pkgs/), so
readers can click the exact bot-command guidance; locate the string
"`@conda-forge-admin`, please update version" in publish_a_new_release.qmd and add
the links inline near that sentence.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 47dd1f82-5fdb-47b3-816c-495a888c0888

📥 Commits

Reviewing files that changed from the base of the PR and between fc4e8be and 6da4296.

📒 Files selected for processing (3)
  • .agents/agents.md
  • .agents/skills/start_task/SKILL.md
  • docs/contributing/publish_a_new_release.qmd

Comment thread docs/contributing/publish_a_new_release.qmd Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6da4296760

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


The GitHub releases page can generate release notes automatically, but maintainers should review and edit the generated text so it is useful to users. Also note, DASCore includes and agent skill called "draft release" so a coding agent of your choice can help you do this. In the changelog, prefer concise descriptions of behavior and API changes over internal implementation details. Include pull request links when they help readers find more context.

Then click 'Publish Release'. This will kick off the doc-build and publishing task automatically, as well as publish the tagged source code to PyPI.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Correct release trigger description for stable docs build

This sentence says clicking Publish Release will start both package and docs publishing automatically, but the workflows are wired to different release events: PublishPackage listens to release.published (.github/workflows/upload_pypi.yml:3-6) while BuildDeployStableDocs listens to release.created (.github/workflows/build_deploy_stable_docs.yaml:4-7). Since the preceding step instructs maintainers to draft first and then publish, maintainers can follow this page and not get the stable docs deployment they are told to expect.

Useful? React with 👍 / 👎.

@d-chambers d-chambers merged commit 689826a into master May 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant