Skip to content

Conversation

@oskardotglobal
Copy link
Contributor

This PR allows users to re-use morph's eval-machines.nix with any amount of preprocessing since networkExpr is no longer a required argument if network is passed

@adamtulinius
Copy link
Contributor

Hi @oskardotglobal, thanks for the PR. Can you give an example of how this would be used?

@oskardotglobal
Copy link
Contributor Author

You could write your own network parsing logic and then pass it to morph like

# eval-machines.nix
import "${pkgs.morph.lib}/eval-machines.nix" {
  network = {}; # call whatever here
  networkExpr = null;
}

@adamtulinius
Copy link
Contributor

You could write your own network parsing logic and then pass it to morph like

# eval-machines.nix
import "${pkgs.morph.lib}/eval-machines.nix" {
  network = {}; # call whatever here
  networkExpr = null;
}

So just to clarify, it's for using eval-machines.nix outside of morph?
I'm not opposed to the change, it seems harmless no matter what, just looking to understand the use case better

@oskardotglobal
Copy link
Contributor Author

it's for extending eval-machines

@srhb srhb self-requested a review July 23, 2025 06:08
@srhb srhb merged commit a529f37 into DBCDK:master Jul 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants