t/virtual_table/rt_99748.t fails with libsqlite3 3.21.0

[fschlich]

it does not fail with libsqlite3-dev 3.20.1-2 (on Debian), all else being equal

couldn't eval q{sub {my ($self, $i) = @_; my $row = $self->row($i); (defined($row->[1]) && defined($vals[0]) && $row->[1]  $vals[0])}} : syntax error at (eval 19) line 1, near "]  $vals"

#   Failed test 'no warnings'
#   at /usr/share/perl/5.26/Test/Builder.pm line 135.
# There were 2 warning(s)
#       Previous test 23 'SELECT rowid FROM vtb WHERE c = 'six''
#       Use of uninitialized value $op in pattern match (m//) at /home/fs/src/pkg-perl/git/packages/libdbd-sqlite3-perl/blib/lib/DBD/SQLite/VirtualTable/PerlData.pm line 104.
#  at /home/fs/src/pkg-perl/git/packages/libdbd-sqlite3-perl/blib/lib/DBD/SQLite/VirtualTable/PerlData.pm line 104.
#       DBD::SQLite::VirtualTable::PerlData::BEST_INDEX(DBD::SQLite::VirtualTable::PerlData=HASH(0x557070b2ec60), ARRAY(0x557070b277e8), ARRAY(0x557070b271e8)) called at /home/fs/src/pkg-perl/git/packages/libdbd-sqlite3-perl/blib/lib/DBD/SQLite.pm line 202
#       DBD::SQLite::db::prepare(DBI::db=HASH(0x557070b15c60), "SELECT a FROM vtb WHERE b IS NULL ORDER BY a", undef) called at /usr/lib/x86_64-linux-gnu/perl5/5.26/DBI.pm line 1690
#       DBD::_::db::selectcol_arrayref(DBI::db=HASH(0x557070b15c60), "SELECT a FROM vtb WHERE b IS NULL ORDER BY a") called at t/virtual_table/rt_99748.t line 80
#       main::test_table(DBI::db=HASH(0x557070b15d08), "vtb") called at t/virtual_table/rt_99748.t line 57
# 
# ----------
#       Previous test 23 'SELECT rowid FROM vtb WHERE c = 'six''
#       Use of uninitialized value $op in concatenation (.) or string at /home/fs/src/pkg-perl/git/packages/libdbd-sqlite3-perl/blib/lib/DBD/SQLite/VirtualTable/PerlData.pm line 108.
#  at /home/fs/src/pkg-perl/git/packages/libdbd-sqlite3-perl/blib/lib/DBD/SQLite/VirtualTable/PerlData.pm line 108.
#       DBD::SQLite::VirtualTable::PerlData::BEST_INDEX(DBD::SQLite::VirtualTable::PerlData=HASH(0x557070b2ec60), ARRAY(0x557070b277e8), ARRAY(0x557070b271e8)) called at /home/fs/src/pkg-perl/git/packages/libdbd-sqlite3-perl/blib/lib/DBD/SQLite.pm line 202
#       DBD::SQLite::db::prepare(DBI::db=HASH(0x557070b15c60), "SELECT a FROM vtb WHERE b IS NULL ORDER BY a", undef) called at /usr/lib/x86_64-linux-gnu/perl5/5.26/DBI.pm line 1690
#       DBD::_::db::selectcol_arrayref(DBI::db=HASH(0x557070b15c60), "SELECT a FROM vtb WHERE b IS NULL ORDER BY a") called at t/virtual_table/rt_99748.t line 80
#       main::test_table(DBI::db=HASH(0x557070b15d08), "vtb") called at t/virtual_table/rt_99748.t line 57
# 
# Looks like your test exited with 2 just after 24.
t/virtual_table/rt_99748.t ............................ 
1..52
ok 1 - An object of class 'DBI::db' isa 'DBI::db'
ok 2 - create_module
ok 3 - create vtable
ok 4 - SELECT rowid, * FROM rtb: got 3 rows
ok 5 - got 1 in a
ok 6 - got undef in b
ok 7 - got 1 in a
ok 8 - SELECT rowid FROM rtb WHERE c = 'six'
ok 9 - SELECT a FROM rtb WHERE b IS NULL ORDER BY a
ok 10 - SELECT a FROM rtb WHERE b IS NOT NULL ORDER BY a
ok 11 - SELECT a FROM rtb WHERE c IS NULL ORDER BY a
ok 12 - SELECT a FROM rtb WHERE c IS NOT NULL ORDER BY a
ok 13 - SELECT a FROM rtb WHERE c = ?
ok 14 - SELECT a FROM rtb WHERE c = ?
ok 15 - SELECT a FROM rtb WHERE c = ?
ok 16 - SELECT a FROM rtb WHERE c = ?
ok 17 - SELECT a FROM rtb WHERE c = ?
ok 18 - SELECT a FROM rtb WHERE c IS ?
ok 19 - SELECT rowid, * FROM vtb: got 3 rows
ok 20 - got 1 in a
ok 21 - got undef in b
ok 22 - got 1 in a
ok 23 - SELECT rowid FROM vtb WHERE c = 'six'
not ok 24 - no warnings
Dubious, test returned 2 (wstat 512, 0x200)
Failed 29/52 subtests

[charsbar]

Thanks for your report. This seems to be because IS (NOT) NULL support introduced in 3.21.0. Will look at it more later.

[charsbar]

Fixed by da3306e .