Skip to content

Conversation

@mathisonryan
Copy link
Member

@mathisonryan mathisonryan commented Aug 31, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: DBOMproject/enhancements/issues/1

What is the new behavior?

  • Database agent has been updated to support the rich query api

Does this introduce a breaking change?

  • Yes
  • No

Other information

Add rich query support along with list channels and records
Add handling so audit channels are ignored when listing channels
@mathisonryan mathisonryan linked an issue Aug 31, 2021 that may be closed by this pull request
@mathisonryan mathisonryan requested a review from amithkk August 31, 2021 22:05
@mathisonryan mathisonryan self-assigned this Aug 31, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1187909234

  • 145 of 145 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1147556561: 0.0%
Covered Lines: 286
Relevant Lines: 286

💛 - Coveralls

childOf: ctx,
});
// eslint-disable-next-line max-len
return client.db(CHANNEL_DB).listCollections(null, { nameOnly: true }).toArray().then((collections) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Can use await over .then() here

@mathisonryan mathisonryan merged commit 564e4f8 into master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DEP-1] Implementation for rich query

4 participants