Standardize MySQL URL scheme and support inline passwords#151
Merged
Conversation
URL format changed from non-standard mysql://host:port/user@database to standard mysql://user[:password]@host[:port]/database. Similarly for SSH tunnels: mysql+ssh://sshuser@sshhost/mysqluser[:password]@mysqlhost[:port]/database. parseURL() now uses urllib.parse.urlparse instead of fragile regexes. When a password is provided in the URL, keyring lookup is skipped entirely. Also fixes Database.connect() overriding the parsed port with hardcoded 3306. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mysql://host:port/user@databaseto standardmysql://user[:password]@host[:port]/databasemysql+ssh://sshuser@sshhost:mysqlhost/mysqluser@databasetomysql+ssh://sshuser@sshhost/mysqluser[:password]@mysqlhost[:port]/databaseparseURL()now usesurllib.parse.urlparseinstead of fragile regexes formysql://schemeDatabase.connect()silently overriding the parsed port with hardcoded 3306Test plan
🤖 Generated with Claude Code