refactor: API 주소 변경 #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwanhyeon
reviewed
Jun 13, 2021
Collaborator
gwanhyeon
left a comment
gwanhyeon
left a comment
There was a problem hiding this comment.
리뷰가 늦어져서 죄송합니다. 개인적인사정으로 병원 치료때문에 정신이 없었네요 : (
전체적으로 API 명명을 변경하니 명시적으로 바뀐것 같아보이네요. 하나씩 코드부분 확인하면서 동작까지 확인하였습니다.
리뷰 확인 부탁드리겠습니다!
Comment on lines
+44
to
+53
| public void deletePhoto(TrashPhotoDTO.TrashPhotosRequest request, Long userId) { | ||
| List<TrashPhoto> trashPhotos = trashPhotoRepository.findAllById(request.getTrashPhotoIds()); | ||
|
|
||
| List<Long> storagePhotoIds = trashPhotos.stream() | ||
| .map(TrashPhoto::getStoragePhotoId) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| storagePhotoService.delete(userId, new StoragePhotoDTO.DeleteStoragePhotos(storagePhotoIds)); | ||
| trashPhotoRepository.deleteAllByIdIn(request.getTrashPhotoIds()); | ||
| } |
Collaborator
There was a problem hiding this comment.
요청과 일치하는 휴지통 사진이 없습니다.로 체크하는 로직이 사라진 이유가 혹시 있을까요? 만약 request로 들어온 List<Long> trashPhotoIds id리스트가 없는 경우요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #66
여러 사진 휴지통으로 보내기
DELETE /storage-photos , body storagePhotoIds 배열
-> 200 OK, body에 trash-photos 배열
-> 대충 응답을 보고 아 휴지통으로 이동이 되는구나 할 수 있지 않을까, 단건이었으면 201 CREATED에 trash-photos location 헤더 를 넣어주는 식으로 표현 할 수 있겠다 라고 생각했습니다.
휴지통에서 여러 사진 복구
POST /trash-photos/restore, body trashPhotoIds 배열
-> 200 OK, body에 복구된 storage-photos 배열
휴지통 사진에서 사진 삭제 (보관함 사진 삭제)
DELETE /trash-photos, body trashPhotoIds 배열
-> 204