Skip to content

fuse: Fix the reduced queue assignment#83

Merged
bsbernd merged 1 commit into
redfs-ubuntu-noble-6.8.0-58.60from
fix-reduced-queue-distribution-redfs-ubuntu-noble-6.8.0-58.60
Feb 4, 2026
Merged

fuse: Fix the reduced queue assignment#83
bsbernd merged 1 commit into
redfs-ubuntu-noble-6.8.0-58.60from
fix-reduced-queue-distribution-redfs-ubuntu-noble-6.8.0-58.60

Conversation

@bsbernd
Copy link
Copy Markdown
Collaborator

@bsbernd bsbernd commented Feb 4, 2026

The use of bitmap_weight() didn't give the actual index, but always returned the current cpu, which resulted in a totally wrong mapping.

It now just increases a counter for every mapping and ignores cores not in the given (numa) map and then find the index for that.

Also added is a pr_debug(), which can be activated for example with
echo "module redfs +p" >/proc/dynamic_debug/control (Pity that upstream is not open for such debug messages).

@bsbernd bsbernd requested review from hbirth and yongzech February 4, 2026 18:45
The use of bitmap_weight() didn't give the actual index,
but always returned the current cpu, which resulted
in a totally wrong mapping.

It now just increases a counter for every mapping and ignores
cores not in the given (numa) map and then find the index
for that.

Also added is a pr_debug(), which can be activated for example
with
echo "module redfs +p" >/proc/dynamic_debug/control
(Pity that upstream is not open for such debug messages).
@bsbernd bsbernd force-pushed the fix-reduced-queue-distribution-redfs-ubuntu-noble-6.8.0-58.60 branch from 9f278d9 to b4e87e0 Compare February 4, 2026 18:47
Copy link
Copy Markdown
Collaborator

@hbirth hbirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Wasn't this patch upstream as well?

@bsbernd
Copy link
Copy Markdown
Collaborator Author

bsbernd commented Feb 4, 2026

@hbirth This is exactly what Joanne annotated today - upstreaming stalled (because I was persistently busy)

@bsbernd bsbernd merged commit bcbb684 into redfs-ubuntu-noble-6.8.0-58.60 Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants