DF-332 - add file download audit#1093
Closed
jbarnsley10 wants to merge 8 commits intomainfrom
Closed
Conversation
jbarnsley10
changed the title
|
12 tasks
| cause: err | ||
| }) | ||
| ) | ||
| // prettier-ignore |
Contributor
There was a problem hiding this comment.
Can we remove this?
Contributor
Author
There was a problem hiding this comment.
Haha - we could but it's that annoying SonarCloud failure of 'your function is 77 lines long when the limit is 75' and this was an easy workaround
Contributor
There was a problem hiding this comment.
I would remove it and avoid any kind of in-code **-ignores whether it's prettier, eslint or similar unless absolutely necessary. I'd rather we ignored Sonar, or fix what it's asking us to so the next person doesn't have to.
| false, | ||
| sessionNames.validationFailure.fileDownload | ||
| ) | ||
| // prettier-ignore |
Contributor
There was a problem hiding this comment.
Can we remove this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket DF-332
Adds file download audit
Needs to get deployed in tandem with PR DEFRA/forms-submission-api#385 so that the API calls match