Skip to content

TGC-796: Allow dynamic summaryPath config for back links#173

Closed
davidatdefra wants to merge 3 commits intomainfrom
TGC-796-dynamic-summary-back-link
Closed

TGC-796: Allow dynamic summaryPath config for back links#173
davidatdefra wants to merge 3 commits intomainfrom
TGC-796-dynamic-summary-back-link

Conversation

@davidatdefra
Copy link
Copy Markdown
Contributor

Proposed change

Allow pages that extend SummaryPageController to override getSummaryPath to specify a url path to use when returning from the "Change" action. Will fallback to using the existing /summary hardcoded path if getSummaryPath is not implemented.

Jira ticket: Done in order to support TGC-796

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

@davidatdefra
Copy link
Copy Markdown
Contributor Author

@davidjamesstone @alexluckett Let me know if you have any questions on this. Assuming you think this is a good idea, will need some guidance from you on where to best document the change.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant