Don't assume the main form element is the only form on the page#315
Merged
davidjamesstone merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
|
alexluckett
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed change
We have code in the client JS that explicitly codes around clicking buttons within the map causing a submit event to our main form. It would be nice if we didn't have to do this and it was handled inside the interactive map.
The current workaround code wasn't expecting there to be two forms which is the case when GA is enabled and there's a cookie banner present.
This fixes the issue by looking to the closest
<form>rather than the first in the DOMJira ticket: https://eaflood.atlassian.net/browse/DF-876
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).