Feat/df 1086: Geometry type restrictions

[jbarnsley10]

Proposed change

Allows the form definition to specify which geometry types (point, line or shape) are allowed to be entered in the map (Geospatial component)

Jira ticket: DF-1086

Type of change

• Bug fix
• New feature
• Breaking change
• Misc. (documentation, build updates, etc)

Checklist

• You have executed this code locally and it performs as expected.
• You have added tests to verify your code works.
• You have added code comments and JSDoc, where appropriate.
• There is no commented-out code.
• You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
• The tests are passing (npm run test).
• The linting checks are passing (npm run lint).
• The code has been formatted (npm run format).

[alexluckett]

probably more futureproof to replace this with a join?

  if (items.length === 2) {
    return items.join(' or ')
  }

  const last = items.pop()
  return `${items.join(', ')} or ${last}`

bonus points if you split out the two into a business logic function and a formatting function, e.g.

function formatDelimitedList(items, separator, lastSeparator) {}
function getAllowedTypesPhrase(allowPoint, allowLine, allowShape) // calls formatDelimitedList(items, ',', 'or')

[davidjamesstone]

I wonder if a string[] would be better here?
Otherwise, if we introduce more geometry types later e.g. multipoint, multiline the string.includes below might give false positives.

[jbarnsley10]

Yes, I think that's a good point. It has to be a string when coming from dataset attributes, but I could parse into an array here.

[jbarnsley10]

Pushed

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud