Merged
Conversation
* Initial for mardown declaration in V2 * Handles markdown component * CHanges after review
Bumps the npm_and_yarn group with 2 updates: [esbuild](https://github.com/evanw/esbuild) and [tsx](https://github.com/privatenumber/tsx). Updates `esbuild` from 0.23.0 to 0.25.0 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2024.md) - [Commits](evanw/esbuild@v0.23.0...v0.25.0) Updates `tsx` from 4.19.2 to 4.19.3 - [Release notes](https://github.com/privatenumber/tsx/releases) - [Changelog](https://github.com/privatenumber/tsx/blob/master/release.config.cjs) - [Commits](privatenumber/tsx@v4.19.2...v4.19.3) --- updated-dependencies: - dependency-name: esbuild dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: tsx dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Feature flag GA * Delete unused t&c page
* Set mimeTypes to undefined when initiating a CDP upload if accept string is empty * Omit the accept html attribute if empty
* Allow more than 1 error message for UK Address Field components * Sonar changes * Refactor to getViewErrors * Add comments
…nal items (#753) * Validate answers of fields that are bound to lists that have conditional item * Add missing YesNoField from isListFieldType helper * Add error message if conditional list items become invalid * Sonar changes * Add condition list item unit tests * Update conditional items validation error message
* Bump @defra/forms-model from 3.0.409 to 3.0.438 Bumps [@defra/forms-model](https://github.com/DEFRA/forms-designer/tree/HEAD/model) from 3.0.409 to 3.0.438. - [Commits](https://github.com/DEFRA/forms-designer/commits/HEAD/model) --- updated-dependencies: - dependency-name: "@defra/forms-model" dependency-version: 3.0.438 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * test: 537088 - Fix linting and test errors with new schema --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chris Cole <whitewaterdesign>
* fix(bug): Enhance error handling in file upload component by preventing duplicate error summaries and improving accessibility. Added inline error styling and ARIA attributes to file input for better user experience. Updated tests to verify new behavior. * test: Add inline error styling test for file input field in file upload component * refactor: Replace hardcoded ARIA attributes with constants for improved maintainability and readability in file upload component
…ror summary title element (#773) * Enhance accessibility in file upload component by conditionally setting or removing aria-describedby attribute based on the presence of an error summary title element. Added unit tests to verify the new behavior for both scenarios. * Refactor file upload component to use constants for ARIA attributes, enhancing maintainability and readability. This change improves accessibility by ensuring consistent usage of the error summary title ID throughout the error handling logic.
* feat: 537088 - Disable incorrect eslint rules * feat: 537088 - Use shortDescription for TextField label * build: fix jest setup * feat: 526386 - Use shortDescription for ListFormComponents label * feat: 526386 - CheckboxesField * feat: 526386 - Use shortDescription for label on EmailAddressField * feat: 526386 - Use shortDescription for label on FileUploadField * feat: 526386 - Use shortDescription for label on MultilineTextField * feat: 526386 - Use shortDescription for label on NumberField * feat: 526386 - Use shortDescription for label on TelephoneNumberField * feat: 526386 - Use shortDescription for label on Date parts fields * feat: 526386 - PR updates --------- Co-authored-by: Chris Cole <whitewaterdesign>
…tters (#775) * Changed the wording in the output formatters to specify that the form received is associated with its name, enhancing clarity in the generated messages. * Updated test cases to reflect the new message format, ensuring consistency across the application.
* Initial implementation * Fixed failing tests * Added component tests * Stash * Added tests * SonarCloud lint * Complexity issue * After review * Reduce method lines * Extra tests * Feat/532357 extra error messages (#777) * Extra error messages * Moved code location out of plugin * Stash during types change * Fixed types * Sorted type issues * Removed unnecessary isErrorPreview stuff * Corrected typo * Changed 'close' link in error preview * Added full stop Moved method out of ComponentBase
* Enhanced error messages for MultilineTextField and YesNoField Added file upload errors messages * Reworked YesNo required error * Updated forms-model version * npm audit fix to remove high vulnerability * After review * Reverted reducer code as seems more complicated to understand * feat: 541181 - Optional update * Revert "feat: 541181 - Optional update" This reverts commit 33d7abb5e17a741530936f06b9de34b3d0f811b6. * Changed algorithm for file types list --------- Co-authored-by: Chris Cole <whitewaterdesign>
* feat: 537088 - Disable incorrect eslint rules * feat: 537088 - Use shortDescription for TextField label * stash * feat: 526386 - Show label for summary label * revert: 526386 - Revert ComponentBase change * revert: 526386 - Revert ComponentBase change 2 --------- Co-authored-by: Chris Cole <whitewaterdesign>
…dation (#782) * Refactor: Update server routing and request handling - Changed Jest configuration to enable output logging. - Enhanced server request handling to redirect legacy paths for forms and previews, validating slugs and states against schemas. - Introduced a new proxy route for upload status checks with appropriate validation. - Updated engine plugin to ensure form paths are prefixed correctly. - Improved error handling for invalid paths and states, providing clearer responses. - Refactored path generation in PageController for consistency and clarity. * refactor: Removed unnecessary route prefix from plugin registration in the server setup. * refactor: Update plugin registration to spread plugin engine array and improve return type structure in configureEnginePlugin * refactor: refactored checkFormStatus() to dynamically calculate state index based on prefix depth * fix: checkFormStatus logic and tests * test: update base path in tests with form namespace prefix * test: add tests for onRequest hook legacy redirects * refactor: Removed redundant else block * test: added test for logger and boom error messages * Use prefix from server.realm * Simplify the checkFromStatus method * refactor: remove onRequest hook and simplify namespace changes * test: remove onRequest tests * test: fix feedback link tests * feat: add buildUploadStatusUrl function and refactor legacy redirect handling - Introduced to construct upload status URLs based on the current pathname and upload ID. - Refactored legacy redirect logic in the router to use a new helper function for improved readability and maintainability. - Added unit tests for to ensure correct URL construction across various scenarios. * test: legacy redirect routes * test: use form prefix var * refactor: move handler outside of options * fix: used checkFormStatus helper for preview mode --------- Co-authored-by: David Stone <davidjamesstone@gmail.com>
* Fixup page titles when empty * Sonar
|
davidjamesstone
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Azure DevOps work item:
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).