Calls setWorkerUrl instead of constructor prop fix#242
Merged
dannyleech merged 2 commits intomainfrom Apr 27, 2026
Merged
Conversation
markfee
approved these changes
Apr 27, 2026
Collaborator
markfee
left a comment
markfee
left a comment
There was a problem hiding this comment.
1 minor change required pls
|
|
||
| it('rejects with a truncated SVG preview and revokes the blob URL on error', async () => { | ||
| const originalImage = globalThis.Image | ||
| it('sets img.src to a data URI rather than a blob URL', async () => { |
Collaborator
There was a problem hiding this comment.
I don't think you need 'rather than a blob URL' as that is being removed, so no need to state that here.
Otherwise it's a bit like an MOT requiring a check that the car works without someone having to crank the engine first (ie the way it used to be done).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.