Skip to content

Update security standards#125

Merged
johnwatson484 merged 5 commits into
mainfrom
update-security
May 8, 2026
Merged

Update security standards#125
johnwatson484 merged 5 commits into
mainfrom
update-security

Conversation

@johnwatson484
Copy link
Copy Markdown
Member

@johnwatson484 johnwatson484 commented May 1, 2026

Updating security standards to make greater reference to GitHub Advanced Security and npm config.

Copy link
Copy Markdown
Contributor

@ben-sagar ben-sagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of thoughts

Comment thread docs/guides/continuous_integration.md Outdated
- Use [Hakiri](https://hakiri.io/) for Ruby projects
#### Dependabot

Enable [Dependabot](https://docs.github.com/en/code-security/dependabot) in each repository to automatically raise pull requests when vulnerable or outdated dependencies are detected. Before enabling Dependabot, ensure the [dependency graph](https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/about-the-dependency-graph) is enabled.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good guidance, but the setting might be about to be enforced - it might be worth saying something about this in here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only I'd waited an hour!

Added a note. Once it's enabled, I'll create another PR to tweak the text further.

Comment thread docs/standards/node_standards.md Outdated
| Setting | Purpose |
|---|---|
| `save-exact=true` | Saves exact dependency versions rather than version ranges. Prevents version-range drift from silently pulling in a later, potentially vulnerable release. |
| `ignore-scripts=true` | Prevents npm from running lifecycle scripts such as `preinstall` and `postinstall` during package installation. This blocks a common vector for arbitrary code execution from malicious or compromised packages. Note: some packages that compile native bindings require lifecycle scripts to function. Test your project after enabling this setting and explicitly allow any packages that genuinely need it. |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicitly allow any packages that genuinely need it

Could be helpful to mention / link to how to do this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

### Package Management
- Use NPM.
- Use npm.
- Use a package.json and package-lock.json for repeatable builds.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could maybe add a comment here to stress using npm ci. Something like:

  • Use npm ci instead of npm install in CI/CD pipelines and production builds. It installs exactly what is in the lockfile and fails if the lockfile is out of sync with package.json.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. Updated.

latest patches.
- Separate dependencies and dev dependencies.
- Update your version number inline with the [semantic versioning standard](https://semver.org/).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible additional standard:

  • Vet third-party packages before installing them. Check the repository, maintainer history, download statistics and open issues.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added new point as suggested directing to the guide.

Copy link
Copy Markdown
Contributor

@pmshaw15 pmshaw15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@johnwatson484 johnwatson484 merged commit ecbe24f into main May 8, 2026
@johnwatson484 johnwatson484 deleted the update-security branch May 8, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants