Fix unsafe URL launch in AttachesRenderer#21
Merged
RZEROSTERN merged 2 commits intofeat/phase-2-viewer-completeness-part-2from Mar 25, 2026
Merged
Fix unsafe URL launch in AttachesRenderer#21RZEROSTERN merged 2 commits intofeat/phase-2-viewer-completeness-part-2from
RZEROSTERN merged 2 commits intofeat/phase-2-viewer-completeness-part-2from
Conversation
21 tasks
…strict to http/https, check canLaunchUrl Co-authored-by: RZEROSTERN <3065243+RZEROSTERN@users.noreply.github.com> Agent-Logs-Url: https://github.com/RZEROSTERN/editorjs-flutter/sessions/97759922-db09-4059-af45-b959591f6f85
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on viewer completeness read-only block types
Fix unsafe URL launch in AttachesRenderer
Mar 25, 2026
6f56057
into
feat/phase-2-viewer-completeness-part-2
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AttachesRendererwas callingUri.parse(throws on malformed input) and passing the result directly tolaunchUrlwith no scheme validation, allowing arbitrary URI schemes from document data.Changes
attaches_renderer.dart: Replace unsafe one-liner with the safe async pattern already established inEmbedRendererandLinkToolRenderer:Uri.tryParseinstead ofUri.parse— returnsnullon malformed input rather than throwinghttp/httpsonly) — blocksjavascript:,file:, etc.canLaunchUrlpre-check before invokinglaunchUrl🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.