Optimization and changes for relevant issues.#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major release (v1.2) with significant enhancements to reliability, configurability, and developer tooling for the notification core library. Key improvements include support for PSR-16 token caching, robust automatic retry logic for transient errors, expanded error handling, and a comprehensive CI/CD pipeline with enforced code coverage. Several breaking changes and bug fixes are also included to improve consistency and compatibility.
Major feature additions:
GoogleServiceAccountTokenProvidervia a new constructor argument and config options (cache_key), enabling OAuth tokens to be shared across processes/requests. (src/Auth/GoogleServiceAccountTokenProvider.php,composer.json,README.md,CHANGELOG.md) [1] [2] [3] [4] [5] [6] [7]FcmHttpV1Client, configurable viamax_retriesandretry_base_delay_ms. (src/Auth/GoogleServiceAccountTokenProvider.php,CHANGELOG.md) [1] [2].github/workflows/ci.yml,README.md,CHANGELOG.md) [1] [2] [3]phpunit.xml.dist,.phpunit.result.cache,composer.json,README.md,CHANGELOG.md) [1] [2] [3] [4] [5]Breaking changes and enhancements:
PushTargetnow throws on ambiguous or multiple targets;AndroidOptions::withPriority()throws on unknown values; improved error handling and return types across several classes; widenedpsr/logversion constraint for broader compatibility. (src/Auth/GoogleServiceAccountTokenProvider.php,composer.json,CHANGELOG.md) [1] [2] [3]Documentation and metadata:
README.mdbadges, features, and roadmap to reflect new CI, coverage, and cache/retry capabilities. (README.md,CHANGELOG.md) [1] [2] [3]Testing and developer experience:
psr/simple-cachefor shared token caching. (composer.json,phpunit.xml.dist,CHANGELOG.md) [1] [2] [3]These changes collectively deliver a more robust, configurable, and testable notification core library, preparing it for broader adoption and easier integration into modern PHP projects.