Skip to content

Release 1774

Choose a tag to compare

@github-actions github-actions released this 18 Jun 12:36
bf8fc8c

When the api is unreachable the app raises Rack Timeout exceptions which lead to 500 responses.

Trello card

https://trello.com/c/izJNTyfl

Context

We want to prevent the 500 responses when the dfe api is unreachable

Changes proposed in this pull request

Taking two extra measures to handle the timeouts:

  1. Add the Rack::Timeout::RequestTimeoutException to faraday's retry
    exceptions to give it a second chance to succeed
  2. Rescue the Rack Timeouts and return false to prevent the 500s

Guidance to review