Skip to content

Release 2074

Choose a tag to compare

View all tags
@github-actions github-actions released this 03 Nov 13:53
2074
9ff2da2
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Trello card

Trello

Context

We were sometimes seeing an error that was preventing Google Maps from zooming into the specified location.

To fix use the js-api-loader package to avoid the global callback.

Changes proposed in this pull request

  • Load Google Maps in Stimulus controller instead of using javascript_include_tag to attach a callback to the global object.
  • Update to use the Stimulus.js values API - Stimulus recommend passing data to controllers via the values API instead of the data API.

Guidance to review

Currently, if you go to a school and refresh a few times you will see a console error and the map will not load properly https://schoolexperience.education.gov.uk/candidates/schools/100027

Assets 2
Loading