Release 2179
Trello card
Context
Updates the main candidate registration flow steps to use the GOV.UK form builder components.
Changes proposed in this pull request
-
Use GOV.UK form builder for sign in step
-
Use GOV.UK form builder for personal informations step
Add missing translations for first/last name (the old form builder must have inferred these from the field names).
Checked readonly/disabled state still behaves and double click prevention is still firing.
- Use GOV.UK form builder for contact information step
Adds missing translations.
Checked conditional logic around street label appearing on validation errors.
- Use GOV.UK form builder for education step
Moved translation to work correctly with legend.
Checked various states/errors work as certain fields are shown/hidden depending on radio selection.
-
Use GOV.UK form builder for teaching preference step
-
Use GOV.UK form builder for placement preferences step
Use standard govuk_text_area with max_words option; appears to behave consistently.
Remove overwrite_defaults!: true label option; I'm not sure what this was doing but it doesn't appear to be necessary any longer.
-
Use GOV.UK form builder for background checks step
-
Use GOV.UK form builder for application preview step
Minor update to styling of accept checkbox and surrounding text; the left-margin is lost on the bullet list, which brings it more inline with the examples in the GOV.UK form builder.
- Use GOV.UK form builder for subject/date information step
Guidance to review
The only visual change is on the application preview step, where the bullet list next to the acceptance checkbox is no longer indented. I could probably get it to indent again if anyone feels strongly about it, but it goes against the examples in the form builder so I've left it like this.
| Before | After |
|---|---|
 |
 |