Skip to content

Release 2200

Choose a tag to compare

View all tags
@github-actions github-actions released this 11 Jan 11:53
2200
f5f7c5d
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Trello card

Trello-470
Trello-469

Context

We want to use the latest GOV.UK form builder for all of our forms.

Changes proposed in this pull request

  • Use GOV.UK form builder on confirm attendance form
  • Remove old form builder gem

Guidance to review

Testing this one locally was a pain as you need confirmed bookings that are in the past to test success (you can do this by manually modifying the date of a booking to be in the past then confirm it) and to force an error I hacked the model query scopes to allow it to show a confirmed booking in the future and tried to confirm attendance:

Screenshot 2022-01-11 at 09 50 59

The error summary links don't jump to the correct row, but they don't currently in master either.

Assets 2
Loading