Skip to content

Release 2205

Choose a tag to compare

View all tags
@github-actions github-actions released this 13 Jan 10:41
2205
d18f49d
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Trello card

https://trello.com/c/pk1uu8mE

Context

Some recent updates have broken the Cucumber tests.

Changes proposed in this pull request

  • Fix form when no DBS cost: The value for this currently doesn't work. This means the user will see a validation error, and won't be able to correct it.
  • Fix various selectors: Some of the elements are different in the new form builder. Update the Cucumber tests to match.
  • Update input types: The cucumber tests weren't finding these inputs because they had the wrong type. It is in the GOV guidance to not use the number type for inputs, so I have left that one as text type.
  • Fix labels: Some labels were wrong after the update to the new form builder.
  • Use block for button_to: One of the cucumber selectors was looking for a button element. button_to generates an input usually, but generates a button when using a block.
  • Give text to hidden label: Pass text explicitly to this label as I can't get it to pick up the text from the translations file.

Guidance to review

Currently a single failing test that I can't figure out 🤔

Assets 2
Loading