Skip to content

Release 2215

Choose a tag to compare

View all tags
@github-actions github-actions released this 18 Jan 10:48
2215
5eaf50b
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Trello card

N/A

Context

We have seen a couple of production errors from GOV Notify, where we are attempting to send a SMS to an invalid phone number, or a non-mobile phone number. Check whether numbers are valid mobile numbers before despatching.

Changes proposed in this pull request

  • Only despatch SMS to valid mobile numbers. Also, sanitise numbers because we saw one the other day with a full stop (something like 07777777777.)
  • Fix test: Noticed that this test would have always passed. Make sure it only passes when the correct code is in place.

Guidance to review

Assets 2
Loading