Skip to content

Release 2222

Choose a tag to compare

View all tags
@github-actions github-actions released this 20 Jan 11:55
2222
baebe78
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Trello card

Trello-433

Context

We show outstanding task counts in several places on the dashboard and a running total on the switch school page. At the moment, the running total doesn't always add up to the total displayed on the dashboard, which is confusing to users. We also see a phantom badge appearing over "Manage requests" - when navigating to that section there is no corresponding request to action.

Changes proposed in this pull request

  • Exclude processed requests from those requiring attention

Resolve an issue where a bade was displaying against placement requests but there were no requests in the list when you navigate to it, as they had been cancelled (i.e. processed).

  • Add Bookings::OutstandingTasks to easily summarise by school

At the moment we calculate the outstanding tasks for schools in different places, using different methods. This has resulted in the badges on the dashboard not adding up to the total that is displayed on the school switcher page.

Extract the logic from the dashboard and encapsulate in a new class that we can call and use in both scenarios.

The current scope for the school switcher page is more optimal than this solution, but its impossible to try and reconcile the
logic with the dashboard as it is. This will perform individual requests that can then be totalled; I don't imagine the
efficiency difference will be an issue and this will be far easier to maintain and debug.

In my testing I occasionally got badges showing on the dashboard when there were no corresponding bookings/requests on the detail page. I think there is overlap between requests_requiring_attention and unviewed_withdrawn_requests
at the moment, but that will be addressed in a later PR/commit. For now the aim is to keep it consistent with what the dashboard is displaying.

  • Use OutstandingTasks in DashboardController

Replace custom calls to specific scopes with the OutstandingTasks asbtraction.

  • Update ChangeSchool to use OutstandingTask

By using the OutstandingTask model we are bringing it inline with how the dashboard calculates outstanding tasks.

Guidance to review

Assets 2
Loading