Skip to content

Release 2244

Choose a tag to compare

View all tags
@github-actions github-actions released this 28 Jan 12:13
2244
67b14c4
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Trello card

https://trello.com/c/T7AwPYtZ

Changes proposed in this pull request

  1. Use United Kingdom as the search region instead of England: The search region is currently set to England because School Experience is an England-only service. However, when somebody search for a non-England area/address (e.g., Edinburgh), we receive a null result (because 'Edinburgh, England' can't be interpreted by Google Geocoding) and don't log out region and district. Additionally, if they are close to the border and within their chosen radius of any events, the null result means that we won't show these to the user. Update the region to United Kingdom so that we no longer get null results.
  2. Update the logger message so it makes more sense.
  3. Only show "Sorted by distance" when there are two or more results: It doesn't make sense to show this unless there are multiple results, and it makes the search look messy.
  4. Show targeted messages when no results from searches outside England: We want to show a message telling users that this is an England-only service, along with a link to a country specific teacher training resource. Check the address component of the Geocoding result to see if the search was in Northern Ireland, Scotland, or Wales, and display the link and message if there are no results (there could be some results if the search is near to the border).

Guidance to review

Some searches to try in the review app:

  1. Tenby 👈 Wales message
  2. Edinburgh 👈 Scotland message
  3. Belfast 👈 Northern Ireland message
  4. Cardiff 👈 Unchanged because it's within 50 miles of a school, and it was not returning a null result despite not being in England.
  5. Denbighshire 👈 Compare to staging. This returns a null result when Denbighshire, England (staging), but correct result when Denbighshire, United Kingdom (this review app). It is within 50 miles of a school, so we see some results where previously we wouldn't.

Note: It seems that Google is able to interpret most of our searches anyway. It returns the correct location for Cardiff, England, Dumfries, England, LL114UA, England, Maes Carafanau Llanbenwch Caravan Park, England etc. The exceptions seem to be Edinburgh, England, and Denbighshire, England which it doesn't like.

Assets 2
Loading